-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for @deprecated
gates to WIT
#377
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Let me know once there's any implementation to validate this and then we can merge.
Co-Authored-By: Luke Wagner <mail@lukewagner.name>
This is intended to correspond with WebAssembly/component-model#377. Closes bytecodealliance#1683
I've got an initial implementation of this at bytecodealliance/wasm-tools#1687 with the most notable difference being my prior comment where |
Co-authored-by: Luke Wagner <mail@lukewagner.name>
@alexcrichton thanks for putting that PR up; that's great! Also it sounds good to me to require Is there a use case when people might want to combine (Also I wasn't sure what you meant by "stick in the sand" here - I assumed something like: "starting point" and not like "line in the sand"? I had trouble looking it up 😅) |
My thinking for
Oh that's just me mixing up idioms and producing nonsense, you can ignore me. |
Okay, great - that's a good enough motivation for me. I think that means that once we've merged bytecodealliance/wasm-tools#1687 we should be ready to merge this too! edit: modulo removing |
ab9b0df
to
9b6b70c
Compare
This is intended to correspond with WebAssembly/component-model#377. Closes #1683
Co-Authored-By: Alex Crichton <alex@alexcrichton.com>
Closes #374. Adds support for
@deprecated
gates to WIT. While the text in this PR is ready for review now, we should hold off on merging this until we have implementation feedback. Thanks!r? @lukewagner