Add explicit scenarios for feature gate usage #387
Conversation
|
@alexcrichton / @lukewagner / @yoshuawuyts would anyone mind taking a look at this? |
vados-cosmonic
force-pushed
the
explicit-feature-gate-scenarios
branch
from
0a39c42
to
8aef89c
Compare
vados-cosmonic
force-pushed
the
explicit-feature-gate-scenarios
branch
3 times, most recently
from
4c288a4
to
29682a4
Compare
vados-cosmonic
force-pushed
the
explicit-feature-gate-scenarios
branch
from
29682a4
to
d25824a
Compare
|
I just realized that one other change we discussed in #382 that maybe we want to make in this PR (if we want it to fully resolve #382) is the validation requirements (attached to the various gates) of: |
|
@lukewagner thanks that's a great catch -- that little requirement was definitely an eye opener on the code side -- will add! |
|
Kept this particular change separate so it might be easy to review (I added some headings): Would appreciate just a bit more feedback! |
|
Awesome, lgtm, thanks again! Once things are implemented enough to feel good about this PR, lmk and I'll merge this. |
This commit addds some explanation of the intended usage pattern of feature gates in order to make the transition points and functionality easier to identify/reason about. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
explicit-feature-gate-scenarios
branch
from
af0c60e
to
a8e89f7
Compare
|
Yup! I'll squash here and see what I can do about updating implementation in other spots! |
This commit removes the optional `feature` specification from feature gates (`@since`, in particular). This change should simplify the usage of feature gates (see WebAssembly/component-model#387) for more discussion. This is a breaking change for those who were depending on `wit-parser` as `feature` now no longer present. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
This commit removes the optional `feature` specification from feature gates (`@since`, in particular). This change should simplify the usage of feature gates (see WebAssembly/component-model#387) for more discussion. This is a breaking change for those who were depending on `wit-parser` as `feature` now no longer present. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
…#1741) * Remove feature flag from post-stabilization feature gates This commit removes the optional `feature` specification from feature gates (`@since`, in particular). This change should simplify the usage of feature gates (see WebAssembly/component-model#387) for more discussion. This is a breaking change for those who were depending on `wit-parser` as `feature` now no longer present. Signed-off-by: Victor Adossi <vadossi@cosmonic.com> * Update wit-component to not use feature option in since This commit updates `wit-component` to remove reliance on the `feature` option when dealing with post-stabilization (`@since`) feature gates. Signed-off-by: Victor Adossi <vadossi@cosmonic.com> * Update tests to remove optional feature on since gates Signed-off-by: Victor Adossi <vadossi@cosmonic.com> --------- Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
|
Hey @lukewagner so at this point the optional feature is removed (in a semi-breaking manner, those changes should percolate through but have rarely few people affected), anything else I'm missing? We don't have a new version of |
|
Great, thanks again for all the work! |
This commit addds some explanation of the intended usage pattern of feature gates in order to make the transition points and functionality easier to identify/reason about.
Resolves #382