Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions have a method getArg but parameters are the WASM signature's result types #184

Closed
kmiller68 opened this issue Sep 23, 2021 · 2 comments · Fixed by #196
Closed

Comments

@kmiller68
Copy link

Probably a nit but it seems like "arg" might be the wrong term. Perhaps it should be something more generic like at. at also has the upside of working nicely with anything that takes a list in the DOM.

Since it seems silly to make a new issue for something so small but perhaps we should throw a RangeError instead of a TypeError if the requested index out of bounds?

@kmiller68
Copy link
Author

Actually, I think I was misreading the JS spec. They are arguments and not results in the WASM Signature. That said, I think the other questions are still valid.

@Ms2ger
Copy link
Contributor

Ms2ger commented Sep 24, 2021

I'm not sure what you mean by "working nicely with anything that takes a list in the DOM" - you need to pass the tag, so it's not like you can treat it as a list directly.

I guess I don't see either change as much of an improvement, but I don't care deeply either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants