Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filename extension for S-expression test files #94

Closed
sunfishcode opened this issue Sep 30, 2015 · 4 comments
Closed

Filename extension for S-expression test files #94

sunfishcode opened this issue Sep 30, 2015 · 4 comments

Comments

@sunfishcode
Copy link
Member

The test files in ml-proto/test were originally name with a '.wasm' extension. However, we might expect .wasm to eventually be the filename extension for the official binary format. I propose we use '.wase' for the S-expression text format.

I accidentally committed a patch implementing this to master in be2b6ea which renames the files to '.wase', rather than submitting a pull request. I'm happy to revert it, or I'm happy to submit a new patch using some other extension, following whatever consensus we get here.
@lukewagner
Copy link
Member

Good point, this has been bugging me too for a while. .wase sounds ok to me, although I would have gone with .wast (Wasm AST or WASm Test).

@rossberg
Copy link
Member

rossberg commented Oct 1, 2015 via email

@sunfishcode sunfishcode mentioned this issue Oct 1, 2015
Merged
@sunfishcode
Copy link
Member Author

'.wast' works for me. I submitted #100 to implement it.

@sunfishcode
Copy link
Member Author

#100 is merged. Thanks!

dhil pushed a commit to dhil/webassembly-spec that referenced this issue Mar 2, 2023
@aheejin
Add katex submodule to document/core/util (WebAssembly#94)
1d553de 
To sync our spec with the reference type repo, we need this submodule
too.
dhil pushed a commit to dhil/webassembly-spec that referenced this issue Mar 2, 2023
@aheejin
Revert "Add katex submodule to document/core/util (WebAssembly#94)" (W…
b99c97e 
…ebAssembly#116)

This reverts commit 1d553de.

This reverts WebAssembly#94 in an attempt to revert all squashed commits before we
correctly merge upstream commits as the guideline suggests.
rossberg pushed a commit that referenced this issue Sep 4, 2024
@ngzhian
Add some relaxed dot product tests
8697e47 
For #94.
dhil pushed a commit to dhil/webassembly-spec that referenced this issue Oct 21, 2024
@titzer
Fix syntax for handlers in Explainer.md (WebAssembly#94)
0b1af70
rossberg pushed a commit that referenced this issue Nov 6, 2024
@backes
Update JS-test generation after #90 and #92 (#94)
86e22aa 
"index" was renamed to "address". Without this change, all JS tests
generated from the core tests will fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rossberg @sunfishcode @lukewagner