Don't Eval.eval in existing module #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewagner
changed the title
rossberg
added a commit
that referenced
this pull request
Aug 18, 2015
Don't Eval.eval in existing module
|
Thanks for fixing the nits and merging. I was pulled away by a meeting or I would've done it for you; happy to learn the right ML style. |
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Apr 26, 2018
rossberg
referenced
this pull request
in effect-handlers/wasm-spec
Feb 15, 2021
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
Add cont.bind; check handler types
dhil
added a commit
to dhil/webassembly-spec
that referenced
this pull request
Oct 20, 2023
Merge with WebAssembly/gc
rossberg
pushed a commit
that referenced
this pull request
Mar 7, 2024
rossberg
pushed a commit
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Eval.evalevaluates expressions inside the current wasm module (kinda like a JS direct eval) which feels like it violates module encapsulation invariants. This patch mocks up a dummy module.