Use int64 for addresses and sizes, isolate BigArray int limitation #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -4,11 +4,9 @@ | |||
|
|
|||
| type memory | |||
| type t = memory | |||
| type address = int | |||
There was a problem hiding this comment.
Specific reason to remove these instead of making them synonyms for int64? They have some documentation value.
There was a problem hiding this comment.
The reason I removed was that, before, we half treated these as opaque types and, with this PR, we fully assume they are int64s, so it seemed like an unnecessary abstraction. But I wasn't considering the documentation value; I can add them back.
lukewagner
force-pushed
the
mem-addr-type
branch
from
e8fba63
to
ae68e4a
Compare
lukewagner
force-pushed
the
mem-addr-type
branch
from
ae68e4a
to
25c82c1
Compare
|
Updated for comment and rebased. |
|
@rossberg-chromium lgty? |
|
LGTM modulo nits |
|
Merging with nits fixed. |
lukewagner
added a commit
that referenced
this pull request
Oct 7, 2015
Use int64 for addresses and sizes, isolate BigArray int limitation
alexcrichton
pushed a commit
to alexcrichton/spec
that referenced
this pull request
Nov 18, 2019
* Update conversion op names This renaming was decided on in WebAssembly#884.
eqrion
pushed a commit
to eqrion/wasm-spec
that referenced
this pull request
Nov 25, 2019
* Change element segment encoding * Change table index letter
Connicpu
pushed a commit
to Connicpu/wasm-spec
that referenced
this pull request
May 11, 2020
Also add a note that we expect engines to trap when there are 4 billion waiters. See issue WebAssembly#108.
rossberg
pushed a commit
that referenced
this pull request
Feb 11, 2021
Remove type annotation on ref.is_null in overview
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Nov 13, 2023
Fix a few minor issues in local validation rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to address some of the issues raised in #80 by using
int64throughoutspec/. The BigArrayintlimitation is, as suggested in #80, addressed by modeling creation of an array bigger thanmax_intas anOut_of_memorytrap.