Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Fix alignment of i32.store instruction in binary test #1312

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

gumb0
Copy link
Contributor

@gumb0 gumb0 commented Apr 14, 2021

The same problem was already fixed once in #1261, but then was reintroduced in #1287.

Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, that probably got buried under a bulk of merge conflicts. (We keep having a lot of them for binary.wast. Maybe that indicates that we should split it up.)

@rossberg rossberg merged commit f607ec9 into WebAssembly:master Apr 14, 2021
gumb0 added a commit to wasmx/wasm-spec that referenced this pull request Apr 14, 2021
gumb0 added a commit to wasmx/wasm-spec that referenced this pull request Apr 15, 2021
@gumb0 gumb0 deleted the fix-i32store-alignment branch April 16, 2021 15:44
gumb0 added a commit to wasmx/wasm-spec that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants