Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js-api] Update CreateBuiltinFunction call for ES changes. #1337

Merged
merged 2 commits into from
Aug 19, 2021
Merged

[js-api] Update CreateBuiltinFunction call for ES changes. #1337

merged 2 commits into from
Aug 19, 2021

Conversation

Ms2ger
Copy link
Collaborator

@Ms2ger Ms2ger commented Jun 24, 2021

@ANDREISURKOV1987
Copy link

😍

@Ms2ger Ms2ger requested a review from domenic August 17, 2021 09:27
domenic
domenic approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW @syg is probably the best reviewer for these sorts of things in the future.

document/js-api/index.bs Outdated Show resolved Hide resolved
@Ms2ger Ms2ger merged commit ed0f019 into master Aug 19, 2021
@Ms2ger Ms2ger deleted the CreateBuiltinFunction branch August 19, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ANDREISURKOV1987 ANDREISURKOV1987 ANDREISURKOV1987 approved these changes

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ms2ger @ANDREISURKOV1987 @domenic