Second left-to-right test #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added store operations and adjusted the memory size. I already added the four dummy functions, which will be used to test the evaluation order of functions.
| (func $f32_right (result f32) (i32.store8 (i32.const 0) (i32.const 2)) (f32.const 145)) | ||
| (func $f64_left (result f64) (i32.store8 (i32.const 0) (i32.const 1)) (f64.const 163)) | ||
| (func $f64_right (result f64) (i32.store8 (i32.const 0) (i32.const 2)) (f64.const 164)) | ||
| (func $reset (i32.store8 (i32.const 8)(i32.const 0))) |
There was a problem hiding this comment.
I see this was already present in the previous patch, but could you add a space between the ')' and '(' here?
There was a problem hiding this comment.
Oops, next time I'll scan my code for ')(', so hopefully this won't happen again.
|
Other than comments above, looks good to me. |
I added a space between two brackets, fixed the comment and added a new "test to write" to TestingTodo, which will test the evaluation order of call_indirect
|
lgtm, thanks! |
alexcrichton
pushed a commit
to alexcrichton/spec
that referenced
this pull request
Nov 18, 2019
…#135) This PR also centralizes the processing of float-point ops in one file named simd_float_op.py, see WAVM PR: WAVM/WAVM#209
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests if store instructions and calls evaluate their operands from left to right, too.