Remove duplicated binary tests #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those tests were moved to `binary-leb128.wast` in WebAssembly#1019, but WebAssembly#1287 brought them back.
rossberg
reviewed
May 10, 2023
| "\00" ;; Table index 0 | ||
| "\41\00\0b\00" ;; (i32.const 0) with no elements | ||
| ) | ||
|
|
||
| ;; Data segment tags and memory index can have non-minimal length |
There was a problem hiding this comment.
Shouldn't these belong to binary-leb128 as well?
There was a problem hiding this comment.
Ack, but that looks like a separate fix. Will upload.
There was a problem hiding this comment.
(note: will upload after this PR landed to avoid merge conflict)
test/core/binary.wast
Outdated
| "\00\82\80\80\80\80\00" ;; no max, minimum 2 with one byte too many | ||
| ) | ||
| "integer representation too long" | ||
| ) | ||
|
|
||
| ;; Signed LEB128 must not be overlong |
There was a problem hiding this comment.
Oh, right, those are already duplicated. Updated this PR to remove them as well.
rossberg
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those tests were moved to
binary-leb128.wastin #1019, but #1287 brought them back.