Fix rounding in f32.convert_u/i32 and f64.convert_u/i64. #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix interpreter's implementations of f32.convert_u/i32 and f64.convert_u/i64 to round large odd numbers correctly.
|
LGTM, deferring to @gahaas for float expertise |
gahaas
reviewed
Feb 9, 2017
| @@ -15,13 +15,13 @@ let convert_s_i32 x = | |||
|
|
|||
| (* | |||
| * Similar to convert_u_i64 below, the high half of the i32 range are beyond | |||
| * the range where f32 can represent odd numbers. | |||
| * the range where f32 can represent odd numbers, though we do need to adjust | |||
| * the least significant bit to round correctly. | |||
| *) | |||
| let convert_u_i32 x = | |||
There was a problem hiding this comment.
I think f32.convert_u/i64 also needs to be changed.
|
The fix used here isn't sufficient for f32.convert_u/i64; I've now filed #421 for that. |
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Oct 3, 2023
Spec sequential visibility for globals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix interpreter's implementations of f32.convert_u/i32 and f64.convert_u/i64
to round large odd numbers correctly.