Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some tests for call #58

Closed
wants to merge 1 commit into from
Closed

add some tests for call #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions ml-proto/test/calls.wasm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
(module
(func $one
(i32.const 1))

(func $two
(i32.const 2))

(func $add (param i32) (param i32) (result i32)
(i32.add (get_local 0) (get_local 1)))

(func $callone (call $one))
(func $calltwo (call $two))
(func $calladd (param i32) (param i32) (result i32)
(call $add (get_local 0) (get_local 1)))

(export "one" $one)
(export "two" $two)
(export "add" $add)
(export "callone" $callone)
(export "calltwo" $calltwo)
(export "calladd" $calladd)
)

(assert_eq (invoke "one") (i32.const 1))
(assert_eq (invoke "two") (i32.const 2))

(assert_eq (invoke "add" (i32.const 1) (i32.const 2)) (i32.const 3))

(assert_eq (invoke "callone") (i32.const 1))
(assert_eq (invoke "calltwo") (i32.const 2))
(assert_eq (invoke "calladd" (i32.const 1) (i32.const 2))
(i32.const 3))

(; the following test fails
(assert_eq (invoke "calladd" (invoke "callone") (invoke "calltwo"))
(i32.const 3))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason this fails is that the first argument to assert_eq isn't an arbitrary expression, it must be a fixed form (assert_eq (invoke ...) ...). This relates to trying to limit how much expression evaluation happens in the scripting language, compared to within real wasm code.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I create a second module that exports functions called "test{feature}" and then on outer asserts call those?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite follow what you're suggesting. In general, we try to do most of the computation inside wasm and then just assert the result (or, when #54 merges, printing output and asserting output match with a .log file in expected-output).

;)