Avoid relying on correct rounding of mod_float. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
sunfishcode
added a commit
that referenced
this pull request
Sep 18, 2015
Avoid relying on correct rounding of mod_float.
eqrion
pushed a commit
to eqrion/wasm-spec
that referenced
this pull request
Jul 18, 2019
awendland
pushed a commit
to awendland/webassembly-spec-abstypes
that referenced
this pull request
Mar 26, 2020
rossberg
pushed a commit
that referenced
this pull request
Nov 6, 2024
* Fix hardcoded use of i32 in call_indirect and return_call_indirect * Add missing prose for table type in table.size * Update table and memory type matching This is used for matching external types. * Update store integrity section for index types * Fix rogue backslashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mod_float is not always correctly rounded on all platforms. This patch uses a safer algorithm to check whether a number is even.