Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Now using ocamlbuild for building. Rewrote Makefile, introduces _tags. #83

Merged
merged 3 commits into from
Sep 23, 2015
Merged

Now using ocamlbuild for building. Rewrote Makefile, introduces _tags. #83

merged 3 commits into from
Sep 23, 2015

Conversation

lindig
Copy link
Contributor

@lindig lindig commented Sep 21, 2015

.gitignore is simplified since now almost all build files reside in _build.
Using "git archive" to build a zip file in target "zip".

@lindig
Now using ocamlbuild for building. Rewrote Makefile, introduces _tags.
686049b 
.gitignore is simplified since now almost all build files reside in _build.
Using "git archive" to build a zip file in target "zip".
@lindig
Copy link
Contributor Author

lindig commented Sep 21, 2015

I'd like to suggest to use OCamlbuild for the build process (but still controlled by a Makefile). This results in a simpler build specification and a cleaner build structure as source and build files are better separated. The main change is in the Makefile, which could be integrated as Makefile.ocb to keep new and old versions for a while.

@lindig
Copy link
Contributor Author

lindig commented Sep 21, 2015

I didn't realise that using ocamlbuild is already discussed in another pull request. This is somewhat simpler in comparison as it wants to use ocamlbuild but does not pull in other tools like merlin or oasis.

@lindig
Copy link
Contributor Author

lindig commented Sep 22, 2015

This Makefile uses ocamlbuild but no longer requires ocamlfind. Hence, it now works with the OCaml standard distribution.

@sunfishcode sunfishcode mentioned this pull request Sep 22, 2015
Closed
@rossberg
Copy link
Member

Looks good, but for legal reasons, you will have to join the W3C WebAssembly community (https://www.w3.org/community/webassembly/).

@kg, should the test script be adapted to go through make now, so that it doesn't have to duplicate the build parameter logic?

@kg
Copy link
Contributor

kg commented Sep 22, 2015

@kg, should the test script be adapted to go through make now, so that it doesn't have to duplicate the build parameter logic?

This would mean the only way to use this stuff on Windows would be to install Cygwin. But that seems to basically be the case already w/ocaml, so I guess I'm fine with it.

@rossberg
Copy link
Member

rossberg commented Sep 22, 2015 via email

@lindig
Copy link
Contributor Author

lindig commented Sep 22, 2015

I joined W3C and the WebAssembly Community: https://www.w3.org/users/83026.

@rossberg
Copy link
Member

LGTM. Test runner changes can be a follow-up.

rossberg added a commit that referenced this pull request Sep 23, 2015
@rossberg
Merge pull request #83 from lindig/ocamlbuild
261f0a1 
Now using ocamlbuild for building. Rewrote Makefile, introduces _tags.
@rossberg rossberg merged commit 261f0a1 into WebAssembly:master Sep 23, 2015
littledan pushed a commit to littledan/spec that referenced this pull request Mar 4, 2018
@sbc100 @binji
Fix code formatting (WebAssembly#83)
ffe57f4
eqrion pushed a commit to eqrion/wasm-spec that referenced this pull request Jul 18, 2019
@rossberg
[spec] Simplify datacount side condition (WebAssembly#83)
864f382 
* Add definition of free index sets
* Simplify datacount side condition
* Explain convention about multiple occurrences of meta variables
awendland pushed a commit to awendland/webassembly-spec-abstypes that referenced this pull request Mar 26, 2020
@rossberg
[test] call_indirect with multiple tables (WebAssembly#83)
7cfa199
dhil pushed a commit to dhil/webassembly-spec that referenced this pull request Aug 30, 2024
@frank-emrich
Add full code for $scheduler1 and $scheduler2 examples (WebAssembly#83)
5bf661b 
The third section of the explainer currently compares task scheduling using `resume`/`suspend` vs `switch` using two example modules, `$scheduler1`  and `$scheduler2`. The explainer only contains a skeleton of the actual code.

This PR adds `.wast` files containing full code for these modules and links to them in the explainer. The code is carefully written to follow the structure shown in the explainer.
rossberg pushed a commit that referenced this pull request Sep 4, 2024
@dtig
Add entropy.md to discuss fingerprinting, and compat concerns (#83)
b00d451
backes added a commit to backes/spec that referenced this pull request Sep 24, 2024
@backes
wasm-module-builder: Fix left-over use of kWasmStmt WebAssembly#83
e5e94b3 
This was renamed to kWasmVoid in
WebAssembly/memory64@2f5a7c5.
rossberg pushed a commit that referenced this pull request Nov 6, 2024
@backes
wasm-module-builder: Fix left-over use of kWasmStmt (#83)
615bd1f 
This was renamed to kWasmVoid in
WebAssembly/memory64@2f5a7c5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lindig @rossberg @kg