Replaced explicit truncation on memory store with implicit truncation+comment #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,7 +91,8 @@ let load64 mem a = | |||
| Int64.logor (Int64.of_int32 (load32 mem a)) (Int64.shift_left (Int64.of_int32 (load32 mem (a+4))) 32) | |||
|
|
|||
| let store8 mem a bits = | |||
| !mem.{a} <- Int32.to_int (Int32.logand bits (Int32.of_int 255)) | |||
| (* Store "bits" at byte index a; this implicitly truncates all but the lowest 8 bits of "bits". *) | |||
There was a problem hiding this comment.
I apologize for being pedantic, but "truncate" in wasm spec lingo means discarding least-significant digits of a value. How about "this stores just the low 8 bits of "bits", discarding the rest"?
|
lgtm; thanks! Merging based on my own lgtm because this is a minor change that I don't expect will be controversial. |
sunfishcode
added a commit
that referenced
this pull request
Sep 25, 2015
Replaced explicit truncation on memory store with implicit truncation+comment
littledan
pushed a commit
to littledan/spec
that referenced
this pull request
Mar 4, 2018
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Apr 25, 2023
Use plain type substitution instead of type addresses and static/dynamic types
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Oct 21, 2024
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Oct 21, 2024
* Revert "Allow cont ref to be non-null in switch (WebAssembly#85)" This reverts commit 92cbcc5. * Remove other unnecessary `null?` in instruction typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @sunfishcode here