Replace the AST definition in README.md with a link to ast.ml. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | GetLocal of var (* read local variable *) | ||
| | SetLocal of var * expr (* write local variable *) | ||
| | Load of memop * expr (* read memory address *) | ||
| | Store of memop * expr * expr (* write memory address *) | ||
| | LoadExtend of extendop * expr |
There was a problem hiding this comment.
Can you fill in the missing comments on these two?
|
LGTM, but don't forget to update the link when you commit the patch
removing src/. :)
|
sunfishcode
force-pushed
the
dont-duplicate-code-in-readme
branch
from
f9733fc
to
4ec6b98
Compare
The README.md copy keeps going out of date with asm.ml. The ML source code ought to be readable as documentation, since it also serves as a specification, so if there is a readability issue with asm.ml, we should fix it.
sunfishcode
force-pushed
the
dont-duplicate-code-in-readme
branch
from
4ec6b98
to
8786dff
Compare
|
Link updated; thanks! |
sunfishcode
added a commit
that referenced
this pull request
Oct 1, 2015
Replace the AST definition in README.md with a link to ast.ml.
alexcrichton
pushed a commit
to alexcrichton/spec
that referenced
this pull request
Nov 18, 2019
Rename load-and-splat instructions from iNxM.load_splat to vNxM.load_splat
rossberg
pushed a commit
that referenced
this pull request
Feb 11, 2021
* [js-api] Link to the fork for the core specification. * [js-api] More subtyping removal. * [js-api] Fix bugs in Table constructor. * Add an assertion to ToWebAssemblyValue.
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
* Import reference-types repo Source: [WebAssembly/reference-types@d4bc208](https://github.com/WebAssembly/reference-types/tree/d4bc208c0f62ac19529e9e734b10c17c960549e5) * Mention dependency on reference-types repo and add its README.
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
…bAssembly#115) This reverts commit 10d6c6c. This reverts WebAssembly#96, which squashed all upstream commits into one, which was not the recommended way in https://github.com/WebAssembly/proposals/blob/master/howto.md#syncing-with-upstream-changes. This leaves README.md untouched because WebAssembly#99 made significant changes on top of the merged version already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README.md copy keeps going out of date with asm.ml. The ML source
code ought to be readable as documentation, since it also serves as a
specification, so if there is a readability issue with ast.ml, we
should fix it.