Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing stack switching instructions in unfolded form. #100

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

dhil
Copy link
Member

@dhil dhil commented Nov 26, 2024

This patch fixes problems with parsing the stack switching instructions when they appear in unfolded form.

CC @ahuoguo who reported the issue to me.

This patch fixes a problem with parsing the stack switching
instructions when they appear in unfolded form.
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp, since I don't know what issue it fixes. :)

@dhil
Copy link
Member Author

dhil commented Nov 26, 2024

Rubberstamp, since I don't know what issue it fixes. :)

Ah apologies. Prior to this patch the stack switching instructions didn't parse correctly in unfolded form. Also, it wasn't possible to parse an unfolded resume in tail position. I have extended cont.wast with two tests covering parsing of the unfolded form.

@dhil dhil merged commit 5010b4e into WebAssembly:main Dec 3, 2024
1 check passed
@dhil dhil deleted the wat branch December 3, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants