Reference interpreter #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge typed-func-refs proposal
This patch extends the interpreter with a minimal exception handling facility. It is minimal in the sense that it supports only a single exception which can be thrown and caught.
Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
The opcodes for try/catch/throw are taken from the provisional exception-handling proposal.
Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
Extends test suite too.
Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
Minimal exception handling extension
Implement events
Add cont type and instructions
Merge with upstream
Implement the `switch` instruction
Alan-Liang
reviewed
Sep 2, 2024
The evaluator erroneously rewrote `resume_throw $x $y (on ..)` into `Plain (Throw $x)`; but `$x` is a type index, not a tag index. However, rewriting it to `Throw $y` is not correct either, as the throw may be injected into another instance, where `$y` may be absent. Therefore, we rewrite it into an administrative instruction `Throwing (tag_instance, args)` instead such that the tag is fully resolved by before being injected into the continuation.
dhil
added a commit
that referenced
this pull request
Sep 24, 2024
There is a small inconsistency between the reference implementation in #84 and the explainer. In the explainer we write that the type index `$ft` on `cont $ft` should be encoded as an `u32` in the binary format. However, the reference interpreter actually encodes it as `s33`, similarly to how concrete heap types are encoded. I do not have a strong preference for either encoding, but I suppose one can argue that the `s33` approach is more forward compatible in the sense that we can encode additional metadata.
|
Following on from the discussion we had Monday, I've removed the |
|
This is ready for review / to be merged once #90 has been merged. |
|
@tlively and @slindley this patch is ready for review now. PTAL. The patch includes some updates to the legacy proposal documents. I think these should be consolidated under stack-switching/ along side the legacy bag-o-stacks documents (if we decide to keep any of these documents around). But I think that is for another patch. |
dhil
added a commit
that referenced
this pull request
Oct 22, 2024
There is a small inconsistency between the reference implementation in #84 and the explainer. In the explainer we write that the type index `$ft` on `cont $ft` should be encoded as an `u32` in the binary format. However, the reference interpreter actually encodes it as `s33`, similarly to how concrete heap types are encoded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a reference interpreter for the stack switching proposal. It implements all of the proposed instructions.
The patch also includes many updates from WebAssembly/spec, WebAssembly/function-references, WebAssembly/exception-handling, and WebAssembly/gc.
The contents of this patch are comprised of multiple smaller patches which have already been reviewed by @rossberg -- though, if you are keen please take a look.