Update rethrow depth handling and catch_all opcode #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `catch_all` shared an opcode with `else`, but the spec now allocates it the 0x19 opcode.
Previously this had interpreted the rethrow depth argument as counting only catch blocks, but the spec has clarified that it should count all blocks (in a similar fashion as `br` and related instructions).
takikawa
force-pushed
the
exception-fixes
branch
from
6d2d611
to
a1f9e70
Compare
|
Thanks for review! :) I don't have merge permissions so would appreciate someone who does merging this in. |
|
@takikawa It seems you does have the merge access though? You are shown as a "member". Last time I merged your PR because you were shown as a "contributor". I guess you joined the WebAssembly org in the meantime? |
|
Thanks for the merge! @aheejin I did indeed join the org as a member, maybe I also need to request to join a team in the org? I didn't see the merge button in my UI as far as I could tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates exception handling support to match the most recent spec explainer (see WebAssembly/exception-handling#137). In particular, it fixes the handling of
rethrow's depth argument and changes thecatch_allopcode. Tests are also expanded (with test cases taken from spec issue examples).