Switch CI to fully use github actions #167
Conversation
pchickey
force-pushed
the
pch/build_on_ghactions
branch
4 times, most recently
from
99aff3b to
65b8869
Compare
.github/workflows/main.yml
Outdated
| - name: Install clang (Windows) | ||
| shell: cmd | ||
| run: | | ||
| powershell -Command "$ProgressPreference = 'SilentlyContinue'; iwr -outf %TEMP%\LLVM-8.0.0-win64.exe https://rust-lang-ci2.s3.amazonaws.com/rust-ci-mirror/LLVM-8.0.0-win64.exe" |
There was a problem hiding this comment.
Can you remember why we can't use releases.llvm.org for windows? I seem to remember there was a bug? I wonder if updating to 9.0.0 would fix the issue?
There was a problem hiding this comment.
idk, im just trying to translate the stuff thats on azure right now. Lets try upgrading it to 9.0.0 after all this stuff works.
currently stuck on an error about llvm-ar not being found (i think?) on windows, but I have to run for the night before fixing that
There was a problem hiding this comment.
Ended up switching to the llvm release after all, but kept everything at 8.0.0 for now.
pchickey
force-pushed
the
pch/build_on_ghactions
branch
from
fff52bb to
41a3bf7
Compare
| - name: Install clang (Windows) | ||
| shell: bash | ||
| run: | | ||
| curl -fsSLO https://releases.llvm.org/8.0.0/LLVM-8.0.0-win64.exe |
There was a problem hiding this comment.
So this .exe is secretly a 7zip formatted file? Strange.
There was a problem hiding this comment.
I have no idea why this works. I copy-pasted it from somewhere on the internet, and appears to do just fine. I don't have a windows machine on which to even try it, so I only know that it works here :)
.github/workflows/main.yml
Outdated
| shell: bash | ||
| run: | | ||
| # Add --no-self-update as a workaround for | ||
| # https://github.com/microsoft/azure-pipelines-image-generation/issues/1224 |
There was a problem hiding this comment.
Looks like this issue is closed.. can we drop this step completely?
| with: | ||
| # Upload the sysroot folder. Give it a name according to the OS it was built for. | ||
| name: ${{ format( 'sysroot-{0}.tgz', matrix.os) }} | ||
| path: sysroot |
There was a problem hiding this comment.
Hmm, do we need this?
Firstly, it should be platform-independent so at least I would upload only from the linux builder.
Secondly I wonder if we should call it something other than sysroot (maybe wasi-libc-prebuilt?).
Thirdly, does any actually need/want this artifact. I'm not sure that very useful on its own without the rest of wasi-sdk (wasi-sdk already uploads its own complete sysroot for those who have their own clang).
There was a problem hiding this comment.
I think this is useful only for troubleshooting builds. It doesn't cost anything (well, it probably costs Microsoft something in storage, but they have the money) or publish the artifacts anywhere prominent, but authors and reviewers can use it to verify that the sysroot built what they expected on platforms they don't have access to.
Ideally we'd add a separate step that downloads all three artifacts and verifies that they're the same, since we expect the build to be the same on all operating systems.
We do the same thing in wasi-sdk PRs as well, for the same reasons.
There was a problem hiding this comment.
I don't mind uploading for CI/debugging purposes. I was just thinking this might not make sense in the github releases.. is that a separate thing?
There was a problem hiding this comment.
yeah, this is a separate thing from github releases. Agree that its confusing, I had to figure it out the hard way too
I started by porting the azure pipeline to github actions. I ended up changing how we install llvm on windows because some environment var stuff was behaving differently on windows with github vs azure.
Additionally, uploads the built sysroot as an artifact, so it can be retrieved from the "Checks" pane of each PR.