Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to use the name "WASI SDK" consistently #384

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

brettcannon
Copy link
Contributor

Closes #383

Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk
Copy link

hugovk commented Feb 8, 2024

Perhaps also?

-Use a toolchain file to setup the *wasi-sdk* platform.
+Use a toolchain file to setup the *WASI SDK* platform.

@brettcannon
Copy link
Contributor Author

Perhaps also?

-Use a toolchain file to setup the *wasi-sdk* platform.
+Use a toolchain file to setup the *WASI SDK* platform.

The reason I didn't update that is the next line of text says, "or the wasi-sdk-thread platform", suggesting it's being used as a technical term in that situation rather than a name.

@sunfishcode sunfishcode enabled auto-merge (squash) February 8, 2024 20:27
@brettcannon
Copy link
Contributor Author

@sunfishcode the failures look unrelated to the PR.

@sunfishcode sunfishcode disabled auto-merge February 9, 2024 23:23
@sunfishcode sunfishcode merged commit bd96bf0 into WebAssembly:main Feb 9, 2024
3 of 5 checks passed
@brettcannon brettcannon deleted the patch-1 branch February 13, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What's the official name of the project?
3 participants