Refactor handling env vars in CI build #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrown
approved these changes
Jul 22, 2024
|
|
||
| ENV WASI_SDK_CI_TOOLCHAIN_CMAKE_ARGS \ | ||
| -DWASI_SDK_ARTIFACT=arm64-linux \ | ||
| -DRUST_TARGET=aarch64-unknown-linux-gnu |
There was a problem hiding this comment.
If run in some local workflow, these Dockerfiles no longer will produce the expected output (or perhaps even work?). How do you feel about pointing that (potential) user back to main.yml for the proper WASI_SDK_CI_* setup that is expected from them?
There was a problem hiding this comment.
That's right yeah, although that was also already sort of true for the Windows/macOS builds since they've also got configuration in CI that would have to be copied down loacally. I'll leave some notes in the containers though.
This commit updates the handling of various environment variables to centralize them in one location in `main.yml` as part of CI configuration. This removes a few custom-named variables in favor of using explicitly-listed env vars. Additionally this moves some env var management from the CI container files to the github actions config as well to keep everything in one place ideally.
alexcrichton
force-pushed
the
refactor-env-vars
branch
from
6a5672b to
350ac54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the handling of various environment variables to centralize them in one location in
main.ymlas part of CI configuration. This removes a few custom-named variables in favor of using explicitly-listed env vars. Additionally this moves some env var management from the CI container files to the github actions config as well to keep everything in one place ideally.