Replace DEFAULT_SYSROOT usage with Clang config files
#503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream want to deprecate `DEFAULT_SYSROOT`[^1][^2][^3], but one blocker is wasi-sdk's usage of it. Let's try to help that along by switching to using config files[^4] instead. This should result in no user-facing changes in functionality. (If it does, then that's an LLVM bug that should be fixed there.) [^1]: https://reviews.llvm.org/D158218 [^2]: llvm/llvm-project#94284 [^3]: llvm/llvm-project#77537 [^4]: https://clang.llvm.org/docs/UsersManual.html#configuration-files
|
Cool, the fewer magical configuration settings we have to bake into the binaries, the better. |
sunfishcode
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream want to deprecate
DEFAULT_SYSROOT123, but oneblocker is wasi-sdk's usage of it.
Let's try to help that along by switching to using config files4
instead.
This should result in no user-facing changes in functionality. (If it
does, then that's an LLVM bug that should be fixed there.)
Footnotes
https://reviews.llvm.org/D158218 ↩
https://github.com/llvm/llvm-project/issues/94284 ↩
https://github.com/llvm/llvm-project/pull/77537 ↩
https://clang.llvm.org/docs/UsersManual.html#configuration-files ↩