-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setValueCurveAtTime when curve has non-finite values? #1171
Comments
I think this is taken care of already. Allowing sequence<unrestricted float> imag; We might want to change the factory method so that it uses |
Yes, I think using |
Yeah. What would it mean in terms of breakage ? I think it would
work fine.
|
Can't think of any cases where |
|
Change the type of the curve parameter to sequence<float>. This specifies that only finite floats are allowed for the curve. This is a backward-compatible change since Float32Array is a sequence<float> (if all the values in Float32Array are finite floats).
The spec currently doesn't say anything about the values contained in the curve for
setValueCurveAtTime
. Are we allowing any possible value for the curve, including NaN and Infinity?Chrome currently signals an error if the curve contains non-finite values.
Allowing such values would probably very quickly cause NaN to be produced for the automation, probably also causing all downstream nodes to produce NaN for all audio samples. Figuring out why this happened is fairly hard.
The text was updated successfully, but these errors were encountered: