Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WebDriver dfn url error #627

Merged
merged 2 commits into from
May 15, 2024

Conversation

alvinjiooo
Copy link
Contributor

@alvinjiooo alvinjiooo commented May 15, 2024

This PR fixes #626 by correcting the WebDriver spec's dfn url.


Preview | Diff

Copy link
Contributor

@reillyeon reillyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file an issue with the WebDriver spec to have these definitions exported so that we don't have to specify custom biblio entries for them.

@alvinjiooo
Copy link
Contributor Author

Please file an issue with the WebDriver spec to have these definitions exported so that we don't have to specify custom biblio entries for them.

From https://respec.org/xref/?term=error&specs=webdriver
I saw that error is already exported.
I tried to just remove url: dfn-error from spec: WEBDRIVER; but that won't link to the correct anchor in WebDriver spec.
Do you know how we should fix it?

@reillyeon
Copy link
Contributor

See https://speced.github.io/bikeshed/#link-defaults for how to configure disambiguation when multiple specs define a term.

@reillyeon reillyeon merged commit 0fa7040 into WebBluetoothCG:main May 15, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request May 15, 2024
SHA: 0fa7040
Reason: push, by reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 15, 2024
SHA: 0fa7040
Reason: push, by reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 15, 2024
SHA: 0fa7040
Reason: push, by reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request May 15, 2024
SHA: 0fa7040
Reason: push, by reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken references in Web Bluetooth
2 participants