WDSUS-44 PHP 8.0 dependency updates #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khleomix
requested changes
Sep 29, 2023
Downgrading the package because there is a dependency conflict. `npm run lint:js` was returning error that eslint-plugin-prettier package is missing.
|
@khleomix This is ready for your review. |
khleomix
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Thanks @asharirfan I've added additional changes/fixes but nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
WDSUS-44
What type of PR is this? (put an x to all applicable)
Link to test
Description
This PR: