Hotfix/hide svg sprite #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregrickaby
approved these changes
Mar 31, 2021
|
@coreymcollins Like you said, we're discussing other solutions, however this works for now. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Fixes an issue where the SVG sprite wasn't being hidden at the bottom of the page anymore.
This wraps the SVG in a div and hides the div, for now at least. I know we have some workflow changes happening in various branches so this is probably an okay stopgap for now, and maybe we can find a more solid way of doing this in one of those branches.
SCREENSHOTS
OTHER
STEPS TO VERIFY
npm run buildDOCUMENTATION
I don't believe so.