Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the /components/ReactTestComp.js be in jsx format, but be a .js file extension and work as does other .js file #1048

Closed
JoshuaVSherman opened this issue Mar 31, 2018 · 2 comments
Closed

make the /components/ReactTestComp.js be in jsx format, but be a .js file extension and work as does other .js file #1048

JoshuaVSherman opened this issue Mar 31, 2018 · 2 comments
Assignees
@DannyMcwaves

Comments

@JoshuaVSherman
Copy link
Contributor

JoshuaVSherman commented Mar 31, 2018 •
edited
Loading

  • there should be no warnings in console
  • there should be no linter errors

#1057
#1053
@JoshuaVSherman JoshuaVSherman self-assigned this Mar 31, 2018
@JoshuaVSherman
Copy link
Contributor Author

JoshuaVSherman commented Mar 31, 2018 •
edited
Loading

@JoshuaVSherman JoshuaVSherman changed the title make the /classes/ReactComp.js be a .jsx file and have it work as does the .js file (syntax should change), keep both files as examples, thanks make the /classes/ReactComp.js be in jsx format, but be a .js file expension and work as does the .js file (syntax should change), keep both files as examples, thanks Mar 31, 2018
@JoshuaVSherman JoshuaVSherman removed their assignment Mar 31, 2018
@JoshuaVSherman
Copy link
Contributor Author

@DannyMcwaves can you look at what I checked in yesterday and figure out what is missing in our toolings, In Babel I think to it works with jsx format? Also I don't know if we need Flow ?
And something for our linter maybe so jsx format has accepted syntax, maybe I need an atom plug in. I put some links above in this issue. thanks

@JoshuaVSherman JoshuaVSherman changed the title make the /classes/ReactComp.js be in jsx format, but be a .js file expension and work as does the .js file (syntax should change), keep both files as examples, thanks make the /components/ReactTestComp.js be in jsx format, but be a .js file expension and work as does other .js file Apr 5, 2018
@JoshuaVSherman JoshuaVSherman reopened this Oct 5, 2018
@JoshuaVSherman JoshuaVSherman changed the title make the /components/ReactTestComp.js be in jsx format, but be a .js file expension and work as does other .js file make the /components/ReactTestComp.js be in jsx format, but be a .js file extension and work as does other .js file Oct 5, 2018
@DannyMcwaves DannyMcwaves mentioned this issue Oct 8, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DannyMcwaves DannyMcwaves

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoshuaVSherman @DannyMcwaves