Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for review on BFCache guides #58

Closed
rakina opened this issue Sep 7, 2022 · 6 comments
Closed

Request for review on BFCache guides #58

rakina opened this issue Sep 7, 2022 · 6 comments
Labels
concerns: venue This proposal is in the wrong standards/incubation venue, or it's not in a venue at all from: Google Proposed, edited, or co-edited by Google. invalid Not an actionable request topic: loading venue: none / personal repository The venue for discussion is a GitHub repository not affiliated with a standards body. venue: W3C TAG Proposal is being reviewed in the W3C Technical Architecture Group

Comments

@rakina
Copy link

rakina commented Sep 7, 2022

Request for review on BFCache guides

Chrome's BFCache team have been working on making sure future web platform APIs will support BFCache by default, which includes adding some BFCache-specific guidelines to W3C's Design Principles and Security & Privacy Questionnaire docs last year. We are now currently in the process of improving the docs and actually factoring out the BFCache guidelines into its own doc (more context here), and we realized recently that we didn't actually get reviews from other browsers last time (it was reviewed only by TAG), so we'd like to formally ask for WebKit's review for these docs:

Thanks a lot :)

@marcoscaceres marcoscaceres self-assigned this Sep 20, 2022
@othermaciej othermaciej added topic: loading venue: W3C TAG Proposal is being reviewed in the W3C Technical Architecture Group from: Google Proposed, edited, or co-edited by Google. labels Sep 25, 2022
@marcoscaceres
Copy link
Contributor

Thanks @rakina! I had a look at the three documents above and all look/read great. I think everyone is generally supportive of bringing more awareness to specification editors about the implications of the BFCache, and how they might impact various APIs/features. In particular, it’s great to have consistent guidance about what to do when a document is in a cached state. It’s also good to see guidance for developers around the use of “pageshow” “pagehide” events, and that APIs should just do the right thing on behalf of developers when possible.

I'm not sure we need to take a "webkit position" here, but I think the aforementioned folks above would be happy to provide input to the documents you listed if they undergo further changes. Just ping us as needed. Have you found a home at the W3C the for "Supporting BFCached Documents" document?

@othermaciej othermaciej added venue: none / personal repository The venue for discussion is a GitHub repository not affiliated with a standards body. concerns: venue This proposal is in the wrong standards/incubation venue, or it's not in a venue at all labels Oct 10, 2022
@othermaciej
Copy link

concerns: venue: the document is proposed for TAG review but seems to currently exist in a personal repo (and Google Docs).

It seems like a good next step is to submit the BFCache guide to the TAG for review.

Also, a minor nit: it might be clearer to call this a "Back/Forward Cache Guide" rather than a "BFCache Guide". "BFCache" (with that capitalization) seems to be a Chromium term, or at best browser developer jargon, and not a standards term.

@rakina
Copy link
Author

rakina commented Oct 10, 2022

Thanks for reviewing! We are currently waiting to get TAG's reply on where to host the new guide for review, I'll update this thread when we get a response. I've also updated the title of the doc to use the full "Back/Forward Cache" but kept most of the text to use the shorter BFCache to keep it short, hope that's ok. If everything looks OK from WebKit's side, is it possible to get the LGTM for the existing PRs?

Also, please let us know if WebKit has a different approach for how features behave with BFCache, in case that doesn't align with what we have in the guide right now. (Since I think there are some Chromium vs WebKit BFCache behavior differences that we noticed, e.g. network requests are immediately dropped when a page is bfcached)

@annevk
Copy link
Contributor

annevk commented Feb 9, 2023

FWIW, I left a number of comments on w3ctag/bfcache-guide#1 but they ended up being ignored.

@rakina
Copy link
Author

rakina commented Feb 9, 2023

Hi @annevk, I'm so sorry that the PR got merged with some unresolved issues still. I was also surprised it got merged so suddenly (I didn't ask for TAG to do that). I'm also sorry for not being able to respond to your comments there quickly, mostly due to my poor scheduling and waiting to get some other input from other people internally. I will make sure I resolve your remaining concerns, and have filed issues for them at w3ctag/bfcache-guide#2 and whatwg/html#8872. We also welcome further suggestions and comments either here or as separate GitHub issues, or in any form really.

Thanks again for taking the time and effort to review the guide thoroughly and other BFCache stuff in general (along with other WebKit folks), I (and the Chromium BFCache team) really appreciate it a lot!

@marcoscaceres marcoscaceres removed their assignment Feb 16, 2023
@hober
Copy link
Member

hober commented Mar 23, 2023

Marking done as Anne left a number of comments on the text.

@hober hober closed this as completed Mar 23, 2023
@annevk annevk added the invalid Not an actionable request label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concerns: venue This proposal is in the wrong standards/incubation venue, or it's not in a venue at all from: Google Proposed, edited, or co-edited by Google. invalid Not an actionable request topic: loading venue: none / personal repository The venue for discussion is a GitHub repository not affiliated with a standards body. venue: W3C TAG Proposal is being reviewed in the W3C Technical Architecture Group
Development

No branches or pull requests

5 participants