Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move out most of "non-fully active" handling guide #392

Merged
merged 16 commits into from
Dec 6, 2022
Merged

Move out most of "non-fully active" handling guide #392

merged 16 commits into from
Dec 6, 2022

Conversation

rakina
Copy link
Contributor

@rakina rakina commented Aug 25, 2022 •
edited by pr-preview bot
Loading

The guide is being moved to a separate "Supporting BFCached documents" doc, to keep the design principles doc short. Replaces the previous content with a short intro and link to the full guide (which is still in my personal repo). See also w3ctag/design-reviews#628 (comment) for context.

Preview | Diff

@rakina
Remove most of "non-fully active" handling guide
cecf1a4 
The guide is being moved to a separate doc, to keep the design principles doc short. Replaces the previous content with a short intro and link to the full guide.
@rakina rakina mentioned this pull request Aug 25, 2022
Closed
1 task
@rakina rakina changed the title Remove most of "non-fully active" handling guide Move out most of "non-fully active" handling guide Aug 25, 2022
@rakina rakina marked this pull request as ready for review August 25, 2022 12:05
@rakina rakina mentioned this pull request Sep 7, 2022
Closed
@rakina rakina mentioned this pull request Sep 29, 2022
Open
@torgo torgo added this to the 2022-10-03-week milestone Oct 2, 2022
@torgo torgo requested a review from cynthia October 5, 2022 15:45
@LeaVerou
Copy link
Member

LeaVerou commented Oct 5, 2022 •
edited
Loading

Hi there, I noticed that the link to the new guide is TODO. I think we should not merge this until that is available, otherwise we're just removing useful guidance without pointing anywhere for finding it.

@rakina
Copy link
Contributor Author

rakina commented Oct 6, 2022

Yep, the plan is to land the BFCache Guide doc first before landing the update to these existing docs.

Is there a good way to get the BFCache Guide doc reviewed? Currently it lives in https://github.com/rakina/bfcache-guide and I can't really make a PR for it because it's a new doc... (How did the Promises guide get reviewed?)

@rakina
Copy link
Contributor Author

rakina commented Nov 9, 2022

Friendly ping for the review for this and the other PRs. Also still don't know where to put the new BFCache doc for review... (@domenic, how did you get to make the https://github.com/w3ctag/promises-guide repo?)

@domenic
Copy link
Member

domenic commented Nov 10, 2022

(@domenic, how did you get to make the https://github.com/w3ctag/promises-guide repo?)

I think I created a separate repo under my own GitHub, and eventually transferred it to the w3ctag. So you're on the right track...

@torgo torgo self-requested a review December 5, 2022 17:45
cynthia
cynthia reviewed Dec 6, 2022
View reviewed changes
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@cynthia
Copy link
Member

cynthia commented Dec 6, 2022

Sorry this took so long, overall the proposed changes look fine to us - and we'd like to do a review of the BFCache guide seprately.

As for that, the repository is here: https://github.com/w3ctag/bfcache-guide
@rakina and @domenic should have write access (on top of the usual TAG suspects)

Wondering how we should review the bfcache-guide repository though, I suppose I could create a PR against the main branch so that we have something to review. Thoughts?

torgo and others added 2 commits December 6, 2022 08:43
@torgo @cynthia
Update index.bs
fcec5a3 
Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>
@torgo @cynthia
Update index.bs
2830700 
Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>
torgo
torgo reviewed Dec 6, 2022
View reviewed changes
index.bs Outdated Show resolved Hide resolved
torgo and others added 9 commits December 6, 2022 08:45
@torgo @cynthia
Update index.bs
51a6738 
Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>
@torgo @cynthia
Update index.bs
efad925 
Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>
@torgo @cynthia
Update index.bs
c13d225 
Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>
@torgo @cynthia
Update index.bs
924869f 
Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>
@torgo @cynthia
Update index.bs
49d7e41 
Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>
@torgo @cynthia
Update index.bs
b375b2d 
Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>
@torgo @cynthia
Update index.bs
73851c9 
Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>
@torgo @cynthia
Update index.bs
627042e 
Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>
@torgo @cynthia
Update index.bs
c8af2d6 
Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>
torgo and others added 2 commits December 6, 2022 08:48
@torgo @cynthia
Update index.bs
5830c7b 
Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>
@torgo
Update index.bs
f314c87
torgo
torgo approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@torgo torgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@cynthia cynthia merged commit 44c0066 into w3ctag:main Dec 6, 2022
@rakina
Copy link
Contributor Author

rakina commented Dec 6, 2022

Thanks @cynthia and @torgo! Looks like https://github.com/w3ctag/bfcache-guide already has the doc committed so maybe we should move that into a separate branch and clear out the main branch, and then make a PR against the main branch?

@cynthia cynthia mentioned this pull request Feb 7, 2023
Closed
hober pushed a commit that referenced this pull request Apr 20, 2023
@rakina @cynthia
@torgo @hober
Move out most of "non-fully active" handling guide (#392)
14d5a33 
* Remove most of "non-fully active" handling guide

The guide is being moved to a separate doc, to keep the design principles doc short. Replaces the previous content with a short intro and link to the full guide.

* Clarify non fully active != BFCache

* Delete index.html

* Update index.bs

Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>

* Update index.bs

Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>

* Update index.bs

Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>

* Update index.bs

Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>

* Update index.bs

Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>

* Update index.bs

Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>

* Update index.bs

Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>

* Update index.bs

Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>

* Update index.bs

Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>

* Update index.bs

Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>

* Update index.bs

Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>

* Update index.bs

Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>

* Update index.bs

Co-authored-by: Sangwhan "fish" Moon <sangwhan@iki.fi>
Co-authored-by: Daniel Appelquist <dan@torgo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torgo torgo torgo approved these changes

@cynthia cynthia cynthia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2022-10-03-week
Development

Successfully merging this pull request may close these issues.
5 participants
@rakina @LeaVerou @domenic @cynthia @torgo