Removed all the dead code. #153
Conversation
|
Also we verify that we manually bump the version in these PRs but should we also update the edition to the current year? |
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 95.39% 95.42% +0.03%
==========================================
Files 32 32
Lines 3037 3037
==========================================
+ Hits 2897 2898 +1
+ Misses 140 139 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -311,16 +311,4 @@ mod test { | |||
| assert_eq!(bexter.qb2().unwrap(), qb2); | |||
| assert_eq!(bexter.bext().unwrap(), bext); | |||
| } | |||
|
|
|||
| fn unhappy() { | |||
There was a problem hiding this comment.
Instead, add an #[rstest] or #[test] tag above
| @@ -102,26 +102,6 @@ pub mod Ids { | |||
| const REVER_STRING: &str = "(?P<ident>[A-Z]{4})(?P<major>[0-9a-f])(?P<minor>[0-9a-f])(?P<kind>[A-Z]{4})(?P<size>[0-9a-f]{6})_"; | |||
| const IDENTS: &[&str] = &[Identage::ACDC, Identage::KERI]; | |||
| const SERIALS: &[&str] = &[Serialage::JSON]; | |||
| const ILKS: &[&str] = &[ | |||
There was a problem hiding this comment.
I believe I use these externally
There was a problem hiding this comment.
I may be wrong though, I may just use Ilkage actually
There was a problem hiding this comment.
Oh I wasn't aware that this library was in use yet. Is it consumed in one of the public WebOfTrust tools or in a private project?
There was a problem hiding this comment.
It's consumed by my company, Qui Identity. I have a KERI/ACDC implementation in Rust in a library we make use of.
There was a problem hiding this comment.
Just checked, I do only use Ilkage:
❯ rg ILKS .
❯ rg Ilkage .
./src/keri/verification.rs
4:use cesride::{common::Ilkage, data::Value, Matter, Sadder, Saider, Seqner, Serder};
11: Ilkage::vcp => serder.pre(),
12: Ilkage::iss | Ilkage::rev => serder.ked()["ri"].to_string(),
./src/keri/parsing.rs
4: common::{Identage, Ilkage},
47: Ilkage::icp | Ilkage::rot | Ilkage::ixn => {
77: Ilkage::vcp | Ilkage::iss | Ilkage::rev => match group {
... and so forth
| @@ -1,5 +1,4 @@ | |||
| // TODO: remove before 1.0.0 | |||
| #![allow(dead_code)] | |||
| #![deny(warnings)] | |||
There was a problem hiding this comment.
You can simply remove this I think
There was a problem hiding this comment.
Oh sorry, I see the change. Nice
|
Added back the |
|
Closes #60 |
Rationale
Just trying to solve the issue to get familiar with the rust tools, the build process, and the warnings.
Simply made warnings -> errors and then removed all the dead code. This may not have been the right thing to do and if so, def let me know what I should have done :D I didn't really ask for clarity so totally glad to redo it with a little direction.
Testing
Ran the tests that were already present and none seemed to break after I removed all this code.
For Reviewers
Cargo.toml