Missing sn in CloneCred after fix in PR #682 #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeairheller
requested changes
Sep 10, 2024
src/keri/vdr/viring.py
Outdated
| status = self.tevers[regk].vcState(saider.qb64) | ||
| schemer = db.schema.get(creder.schema) | ||
|
|
||
| iss = bytearray(self.cloneTvtAt(creder.said, sn=0 if status.et == coring.Ilks.iss else 1)) |
There was a problem hiding this comment.
I don't think this is the appropriate fix because it puts either an issuance event OR a revocation event in a field called "iss". This PR should load and create a rvk field with the revocation event if one exists.
There was a problem hiding this comment.
Should we call the field rvk or rev like in the type field? Also, for a revoked credential, should the response also include the iss ?
There was a problem hiding this comment.
Good call, make it rev. Yes, you might as well include both events.
There was a problem hiding this comment.
I added rev, revatc, revanc and revancatc. And tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #682 omitted specifying
snin the call tocloneTvtAtat line 405. This is important for revoked credentials.See diff changes on line 405 of PR #682
This PR inserts again the
snparameter.Additionally, I corrected the sn used to search in the Tel, sn=0 for
issor sn=1 forrev