fix: strip dev from version when semver comparing for migrations

[iFergal]

This is to address #820 - creating the PR as I'm hitting this issue and now cannot upgrade versions without wiping the DBs.

Also, rc can be in the version too. I haven't covered that in this PR though because then dev1 and rc1 are the same version. Perhaps we can ignore it and just test rc versions in release environments? Open to suggestions!

[kentbull]

I addressed this in a different way my migration PRs here for v1.2.0rc3 and here for v1.1.19 .

Thanks for catching the second version check, I only had the first. My migrations PR is updated to include both.

[iFergal]

Nice @kentbull that looks like a better approach!

I wonder if we should capture the dev or rc using it too. On the other hand, if there's a migration within the same patch version at the dev or rc level, maybe this means the minor or patch should be being bumped!

[kentbull]

if there's a migration within the same patch version at the dev or rc level, maybe this means the minor or patch should be being bumped!

That makes sense to me. Anything significant enough to require a database migration qualifies for a patch bump.

[iFergal]

Cool - I prefer your approach to my quick hack, so I'm going to close this