using jest config to configure default timeout for integration tests #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #169 +/- ##
============================================
Coverage 81.36% 81.36%
============================================
Files 46 46
Lines 4149 4149
Branches 1030 1030
============================================
Hits 3376 3376
Misses 741 741
Partials 32 32 ☔ View full report in Codecov by Sentry. |
pfeairheller
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per suggestion by psteniusubi. But instead of adding "testTimeout" as a cli option, I think it is better to add it as a config. This should ensure it is picked up when running the tests from an IDE as well.
Note that there is actually an option for "testTimeout" that can be set in the config directly. But currently there is an issue with that (jestjs/jest#14513) and it does not look like it will be released in jest v29. When we upgrade, we can avoid the jest.setup.ts file.