fix for attachShadow no longer adding childNodes to shadowRoot #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttraenkler
changed the title
|
fixed this bug in my branch as well |
|
@luwes Thanks! I see you also maintain work on improving shadow DOM support. Are you interested in collaborating on this? I am currently working on supporting |
|
it's up and running |
|
thanks @WebReflection! @ttraenkler happy to collaborate on that. The branch with most of my fixes and improvements are here https://github.com/luwes/linkedom/commits/wesc It's for a project called WeSC https://github.com/luwes/wesc. One of the first goals is to add DSD easily in any project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #178: no longer adds the childNodes of the element to its shadowRoot when attaching a new shadowRoot