Fix #14 - Allow data as attribute

WebReflection · Jun 14, 2020 · 56e99a7 · 56e99a7
1 parent cbff749
commit 56e99a7
Show file tree

Hide file tree

Showing 8 changed files with 93 additions and 12 deletions.
diff --git a/cjs/handlers.js b/cjs/handlers.js
@@ -110,7 +110,9 @@ const handleAttribute = (node, name/*, svg*/) => {
   if (name === 'aria')
     return aria(node);
 
-  if (name === 'data')
+  // some SVG node has the data attribute and if it's used as setter it flicks
+  // see https://github.com/WebReflection/uhtml/issues/14
+  if (name === 'data' && !(name in node))
     return data(node);
 
   if (name.slice(0, 1) === '.')

diff --git a/esm/handlers.js b/esm/handlers.js
@@ -109,7 +109,9 @@ const handleAttribute = (node, name/*, svg*/) => {
   if (name === 'aria')
     return aria(node);
 
-  if (name === 'data')
+  // some SVG node has the data attribute and if it's used as setter it flicks
+  // see https://github.com/WebReflection/uhtml/issues/14
+  if (name === 'data' && !(name in node))
     return data(node);
 
   if (name.slice(0, 1) === '.')

diff --git a/index.js b/index.js
@@ -510,8 +510,10 @@ window.uhtml = (function (exports) {
   /*, svg*/
   ) {
     if (name === 'ref') return ref(node);
-    if (name === 'aria') return aria(node);
-    if (name === 'data') return data(node);
+    if (name === 'aria') return aria(node); // some SVG node has the data attribute and if it's used as setter it flicks
+    // see https://github.com/WebReflection/uhtml/issues/14
+
+    if (name === 'data' && !(name in node)) return data(node);
     if (name.slice(0, 1) === '.') return setter(node, name.slice(1));
     if (name.slice(0, 2) === 'on') return event(node, name);
     return attribute(node, name

diff --git a/min.js b/min.js