Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap certificates in running server after renewal. #1667

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

mrstegeman
Copy link
Contributor

No description provided.

@mrstegeman mrstegeman requested a review from hobinjk February 19, 2019 18:22
@ghost ghost assigned mrstegeman Feb 19, 2019
@ghost ghost added the review label Feb 19, 2019
Copy link
Contributor

@hobinjk hobinjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, unfortunate that there isn't a public API for sharedCreds

@mrstegeman
Copy link
Contributor Author

I know. There's not an official way to do this outside of taking down the server completely and restarting it. I found this solution on the node issue tracker, and everyone seemed satisfied with it.

For reference: nodejs/node#4464

@mrstegeman mrstegeman merged commit 0865c23 into WebThingsIO:master Feb 19, 2019
@ghost ghost removed the review label Feb 19, 2019
@mrstegeman mrstegeman deleted the renew-certs branch February 19, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants