Detect if running inside a snap or on Ubuntu Core #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfrancis
changed the title
benfrancis
force-pushed
the
ubuntu-core-detection
branch
from
1cd3882 to
3c78832
Compare
benfrancis
changed the title
|
@ogra1 Is this the cleanest way of doing this? |
|
Yes, using the system-observe interface is indeed the best way for a snap to know what the actual host environment is. |
dilyn-corner
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in porting WebThings Gateway to Ubuntu Core.
Ubuntu Core does not ship with the
lsb_releasecommand so we have to add some snap-specific code to check for the existence of a distro ID in/var/lib/snapd/hostfs/etc/os-release, which relates to the host OS. See https://forum.snapcraft.io/t/hosts-lsb-release-but-core-os-release/24351/4