Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Node 10 to Node 20 #3176

Merged
merged 13 commits into from
Nov 21, 2024

Conversation

benfrancis
Copy link
Member

@benfrancis benfrancis commented Nov 13, 2024

This PR upgrades the version of Node.js used by WebThings Gateway from version 10 to version 20.

This requires upgrading various npm packages and applying a bunch of TypeScript fixes, and updating the GitHub Action to run using Node.js 20.

TODO:

  • Resolve merge conflicts since NetworkManager PR landed
  • Figure out why integration tests pass but then the process exits with an error
  • Update snap to use Node.js 20
  • [ ] Update docker image to use Node.js 20 Going to do this in a follow-up because the Docker image needs other work doing to it as well

@benfrancis
Copy link
Member Author

@tim-hellhake I think this is nearly ready, I just can't figure out why jest is exiting with an error in CI even though all the tests are passing. Any ideas?

@benfrancis
Copy link
Member Author

benfrancis commented Nov 20, 2024

Finally got the tests to pass!

I'm going to split bb0a1ad out into a separate PR because I don't think it's strictly necessary and I'd like to better understand what we're losing, but otherwise I think this is ready to land.

I intend to keep the full commit history rather than squash them so that we can bisect later if any of these upgrades cause regressions.

@benfrancis benfrancis marked this pull request as ready for review November 20, 2024 22:27
@benfrancis benfrancis force-pushed the node20-upgrade branch 2 times, most recently from b5cfebb to 8e63aa6 Compare November 21, 2024 17:15
@benfrancis
Copy link
Member Author

Ah, it turns out that the deprecated coverage command was also preventing the integration test action from completing successfully after all, so I've added the commit back to remove it.

@benfrancis benfrancis merged commit 8af9ffe into WebThingsIO:master Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants