-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Node 10 to Node 20 #3176
Conversation
cec69c0
to
eb28b55
Compare
3aba713
to
7448140
Compare
7448140
to
7714c27
Compare
@tim-hellhake I think this is nearly ready, I just can't figure out why jest is exiting with an error in CI even though all the tests are passing. Any ideas? |
Finally got the tests to pass! I'm going to split bb0a1ad out into a separate PR because I don't think it's strictly necessary and I'd like to better understand what we're losing, but otherwise I think this is ready to land. I intend to keep the full commit history rather than squash them so that we can bisect later if any of these upgrades cause regressions. |
b5cfebb
to
8e63aa6
Compare
0712be2
to
beacd1c
Compare
Ah, it turns out that the deprecated coverage command was also preventing the integration test action from completing successfully after all, so I've added the commit back to remove it. |
This PR upgrades the version of Node.js used by WebThings Gateway from version 10 to version 20.
This requires upgrading various npm packages and applying a bunch of TypeScript fixes, and updating the GitHub Action to run using Node.js 20.
TODO:
[ ] Update docker image to use Node.js 20Going to do this in a follow-up because the Docker image needs other work doing to it as well