Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark color settings aren't applied for unauthenticated users #13376

Open
2 tasks done
jumase opened this issue Dec 22, 2024 · 2 comments · May be fixed by #13378
Open
2 tasks done

Dark color settings aren't applied for unauthenticated users #13376

jumase opened this issue Dec 22, 2024 · 2 comments · May be fixed by #13378
Assignees
Labels
bug Something is broken.

Comments

@jumase
Copy link

jumase commented Dec 22, 2024

Describe the issue

On latest Weblate version, Codeberg could implement better contrast for dark theme. However, the changing in colors seems to only affect logged in users. Could it be that dark colors are only applied to authenticated users?

I already tried

  • I've read and searched the documentation.
  • I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

  1. Load for example https://translate.codeberg.org/projects/conversations/
  2. Authenticate on that instance and see how color changes

Expected behavior

Colors are the same, whether user is authenticated or not.

Screenshots

authenticated
unauthenticated

Exception traceback

No response

How do you run Weblate?

Other

Weblate versions

Weblate 5.9.2

Weblate deploy checks

No response

Additional context

I'm not aware of how Codeberg implement Weblate. You can see related issue tracker on Codeberg by following this link.

@jumase jumase changed the title Dark color changes aren't applied for unauthenticated users Dark color settings aren't applied for unauthenticated users Dec 23, 2024
@nijel nijel added the bug Something is broken. label Dec 23, 2024
@meel-hd
Copy link
Contributor

meel-hd commented Dec 23, 2024

I'm on it

meel-hd added a commit to meel-hd/weblate that referenced this issue Dec 23, 2024
But only when user is unauthenticated or he chose to.
Otherwise, the colors are defined to match user preference either dark or light.

Close: WeblateOrg#13376
@meel-hd
Copy link
Contributor

meel-hd commented Dec 23, 2024

When users are unauthenticated by default the theme is set to auto (which was before this fix selects incorrect colors). But when the user is logged in, the theme is set to his preference: light or dark instead of the auto theme.

The fix now selects the configured(dark/light) theme colors to match the sytem(dark/light) theme.

@meel-hd meel-hd linked a pull request Dec 23, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants