Permissions language reworked #12449
Conversation
|
Warning Rate limit exceeded@comradekingu has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 27 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| ) | ||
| ) | ||
| if isinstance(obj, Translation): | ||
| component = obj.component | ||
| if obj.is_readonly: | ||
| return Denied(gettext("The translation is read only.")) | ||
| return Denied(gettext("The translation is read-only.")) |
There was a problem hiding this comment.
| return Denied(gettext("The translation is read-only.")) | |
| return Denied(gettext("This is a read-only translation.")) |
Better language, but not consistent form.
| # in PluralTextarea.render | ||
| if unit.readonly: | ||
| if not unit.source_unit.translated: | ||
| return Denied(gettext("The source string needs review.")) | ||
| return Denied(gettext("The string is read only.")) | ||
| return Denied(gettext("The string is read-only.")) |
There was a problem hiding this comment.
| return Denied(gettext("The string is read-only.")) | |
| return Denied(gettext("This is a read-only string.")) |
Better language, but not consistent form.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12449 +/- ##
==========================================
- Coverage 91.11% 91.02% -0.09%
==========================================
Files 589 588 -1
Lines 60258 60256 -2
Branches 9545 9545
==========================================
- Hits 54904 54850 -54
- Misses 3704 3743 +39
- Partials 1650 1663 +13
|
|
This pull request has been automatically marked as stale because there wasn’t any recent activity. It will be closed soon if no further action occurs. Thank you for your contributions! |
|
This pull request has been automatically marked as stale because there wasn’t any recent activity. It will be closed soon if no further action occurs. Thank you for your contributions! |
|
Due to recent cleanups in the templates, this pull request is not something we can easily merge due to massive conflicts. This is caused by the pull request being stale for a long time. This in turn is caused by its size and changing several unrelated files, what makes it challenging to review. Doing smaller pull requests would make the review and merging much easier, please consider it next time. I will extract parts of this into separate pull requests for easier review. |
Inspired by WeblateOrg#12449 by @comradekingu
Extracted from WeblateOrg#12449 by @comradekingu
|
All changes from this are now in separate pull requests. |
Proposed changes
Checklist
Other information