Add support for translatable/readonly for uploaded/downloaded Android Resource Format

docs/changes.rst

@@ -23,6 +23,7 @@ Not yet released.
 * :kbd:`?` now displays available :ref:`keyboard`.
 * Translation and language view in the project now include basic information about the language and plurals.
 * :ref:`bulk-edit` shows a preview of matched strings.
+* :ref:`aresource` now supports translatable attribute in its strings.
 * Creating component via file upload (Translate document) now supports bilingual files.
 
 **Bug fixes**

pyproject.toml

@@ -81,7 +81,7 @@ dependencies = [
   "social-auth-app-django>=5.4.1,<6.0.0",
   "social-auth-core>=4.5.0,<5.0.0",
   "tesserocr>=2.6.1,<2.8.0",
-  "translate-toolkit>=3.13.1,<3.14",
+  "translate-toolkit>=3.13.4,<3.14",
   "translation-finder>=2.16,<3.0",
   "user-agents>=2.0,<2.3",
   "weblate-language-data>=2024.6",

weblate/formats/ttkit.py

@@ -56,6 +56,7 @@
     STATE_APPROVED,
     STATE_EMPTY,
     STATE_FUZZY,
+    STATE_READONLY,
     STATE_TRANSLATED,
 )
 
@@ -543,7 +544,7 @@
             raise ValueError(
                 f"Could not parse flags: {self.mainunit.typecomments!r}: {error}"
             ) from error
         flags.remove({"fuzzy"})
         return flags.format()
 
     @cached_property
@@ -1080,6 +1081,16 @@
         return False
 
 
+class AndroidUnit(MonolingualIDUnit):
+    """Wrapper unit for Android Resource."""
+
+    def set_state(self, state) -> None:
+        """Tag unit as translatable/readonly aside from fuzzy and approved flags."""
+        super().set_state(state)
+        if state == STATE_READONLY:
+            self.unit.marktranslatable(False)
+
+
 class BasePoFormat(TTKitFormat):
     loader = pofile
     plural_preference = None
@@ -1139,7 +1150,7 @@
     def add_unit(self, unit: TranslationUnit) -> None:
         self.store.require_index()
         # Check if there is matching obsolete unit
         old_unit = self.store.id_index.get(unit.unit.getid())
         if old_unit and old_unit.isobsolete():
             self.store.removeunit(old_unit)
         super().add_unit(unit)
@@ -1433,7 +1444,7 @@
     format_id = "aresource"
     loader = ("aresource", "AndroidResourceFile")
     monolingual = True
-    unit_class = MonolingualIDUnit
+    unit_class = AndroidUnit
     new_translation = '<?xml version="1.0" encoding="utf-8"?>\n<resources></resources>'
     autoload: tuple[str, ...] = ("strings*.xml", "values*.xml")
     language_format = "android"
@@ -1681,7 +1692,7 @@
         """Return most common file extension for format."""
         return "csv"
 
     def parse_store(self, storefile):
         """Parse the store."""
         content, filename = self.get_content_and_filename(storefile)
 
@@ -1986,7 +1997,7 @@
 
     def save_content(self, handle) -> None:
         if self.store.root is None:
             self.store.root = self.template_store.store.root
         super().save_content(handle)
 
 

weblate/trans/models/translation.py

@@ -177,10 +177,10 @@
     def __init__(self, *args, **kwargs) -> None:
         super().__init__(*args, **kwargs)
         self.stats = TranslationStats(self)
         self.addon_commit_files = []
         self.reason = ""
         self._invalidate_scheduled = False
         self.update_changes = []
         # Project backup integration
         self.original_id = -1
 
@@ -321,9 +321,9 @@
         except KeyError:
             newunit = Unit(translation=self, id_hash=id_hash, state=-1)
             # Avoid fetching empty list of checks from the database
             newunit.all_checks = []
             # Avoid fetching empty list of variants
             newunit._prefetched_objects_cache = {  # noqa: SLF001
                 "defined_variants": Variant.objects.none()
             }
             is_new = True
@@ -384,7 +384,7 @@
             self.component.check_template_valid()
 
             # List of updated units (used for cleanup and duplicates detection)
             updated = {}
 
             try:
                 store = self.store
@@ -1213,6 +1213,7 @@
                 split_plural(unit.source),
                 split_plural(unit.target) if not self.is_source else [],
                 is_batch_update=True,
+                state=STATE_READONLY if unit.is_readonly() else None,
             )
             existing.add(idkey)
             accepted += 1

weblate/trans/tests/data/strings-with-readonly.xml

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <string name="string_one">String One</string>
+    <string name="string_two" translatable="false">String Two</string>
+    <string name="string_three">String Three</string>
+</resources>

weblate/trans/tests/test_files.py

@@ -16,6 +16,7 @@
 from weblate.trans.models import Change, ComponentList
 from weblate.trans.tests.test_views import ViewTestCase
 from weblate.trans.tests.utils import get_test_file
+from weblate.utils.state import STATE_READONLY
 
 TEST_PO = get_test_file("cs.po")
 TEST_CSV = get_test_file("cs.csv")
@@ -29,6 +30,7 @@
 TEST_MO = get_test_file("cs.mo")
 TEST_XLIFF = get_test_file("cs.poxliff")
 TEST_ANDROID = get_test_file("strings-cs.xml")
+TEST_ANDROID_READONLY = get_test_file("strings-with-readonly.xml")
 TEST_XLSX = get_test_file("cs.xlsx")
 TEST_TBX = get_test_file("terms.tbx")
 
@@ -380,6 +382,43 @@ def test_replace(self) -> None:
             translation.change_set.filter(action=Change.ACTION_REPLACE_UPLOAD).exists()
         )
 
+    def test_readonly_upload_download(self) -> None:
+        """Test upload and download with a file containing a non-translatable string."""
+        project = self.component.project
+        component = self.create_android(name="Component", project=project)
+        self.user.is_superuser = True
+        self.user.save()
+        with open(TEST_ANDROID_READONLY, "rb") as handle:
+            response = self.client.post(
+                reverse(
+                    "upload",
+                    kwargs={"path": component.source_translation.get_url_path()},
+                ),
+                {
+                    "file": handle,
+                    "method": "replace",
+                    "author_name": self.user.full_name,
+                    "author_email": self.user.email,
+                },
+                follow=True,
+            )
+        messages = list(response.context["messages"])
+        self.assertIn("updated: 3", messages[0].message)
+        unit = component.source_translation.unit_set.get(context="string_two")
+        self.assertEqual(unit.state, STATE_READONLY)
+
+        response = self.client.get(
+            reverse(
+                "download",
+                kwargs={"path": component.source_translation.get_url_path()},
+            ),
+            follow=True,
+        )
+        self.assertIn(
+            'name="string_two" translatable="false"',
+            response.getvalue().decode("utf-8"),
+        )
+
 
 class CSVImportTest(ViewTestCase):
     test_file = TEST_CSV