Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show review from terminal options to settings.json #530

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

7h3Rabbit
Copy link
Collaborator

@7h3Rabbit 7h3Rabbit commented Jun 12, 2024

Today when running webperf-core you can specify to show review(s) in terminal by using -r or --review for current run.

In this PR we make it possible to specify it in settings.json and have it persistent between runs:

{
    "general": {
        "review": {
            "show": true
        }
}

You can also use the longer form for use during current run:
python default.py --setting general.review.show=true -i sites.json

you should see this as the first steps of moving more and more options into settings.json.

@7h3Rabbit 7h3Rabbit added the enhancement New feature or request label Jun 12, 2024
@7h3Rabbit 7h3Rabbit changed the title Add show in terminal option to settings.json Add show review in terminal option to settings.json Jun 12, 2024
@7h3Rabbit 7h3Rabbit merged commit 30bd77e into main Jun 12, 2024
@7h3Rabbit 7h3Rabbit deleted the setting-review branch June 12, 2024 18:21
@7h3Rabbit 7h3Rabbit changed the title Add show review in terminal option to settings.json Add show review from terminal options to settings.json Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant