Add show review from terminal options to settings.json #530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today when running webperf-core you can specify to show review(s) in terminal by using
-r
or--review
for current run.In this PR we make it possible to specify it in
settings.json
and have it persistent between runs:You can also use the longer form for use during current run:
python default.py --setting general.review.show=true -i sites.json
you should see this as the first steps of moving more and more options into
settings.json
.