Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TiDE modules and implement it as an imputation model #402

Merged
merged 4 commits into from
May 13, 2024

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. fixing Add TiDE #393;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@WenjieDu WenjieDu changed the base branch from main to dev May 10, 2024 15:21
@coveralls
Copy link
Collaborator

coveralls commented May 12, 2024

Pull Request Test Coverage Report for Build 9064065136

Details

  • 190 of 193 (98.45%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 83.606%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/imputation/tide/model.py 67 70 95.71%
Totals Coverage Status
Change from base Build 9058842458: 0.3%
Covered Lines: 9292
Relevant Lines: 11114

💛 - Coveralls

@WenjieDu WenjieDu marked this pull request as ready for review May 13, 2024 13:41
@WenjieDu WenjieDu merged commit 59985e3 into dev May 13, 2024
8 checks passed
@WenjieDu WenjieDu deleted the (feat)add_tide branch May 13, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants