Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GRU-D as an imputation model #417

Merged
merged 2 commits into from
May 17, 2024
Merged

Add GRU-D as an imputation model #417

merged 2 commits into from
May 17, 2024

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. fixing Implement GRU-D as an imputation model #416;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

@WenjieDu WenjieDu marked this pull request as ready for review May 17, 2024 09:13
@coveralls
Copy link
Collaborator

coveralls commented May 17, 2024

Pull Request Test Coverage Report for Build 9125845957

Details

  • 131 of 134 (97.76%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 84.029%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/imputation/grud/data.py 41 44 93.18%
Files with Coverage Reduction New Missed Lines %
pypots/forecasting/csdi/model.py 1 83.82%
Totals Coverage Status
Change from base Build 9124698085: 0.2%
Covered Lines: 9665
Relevant Lines: 11502

💛 - Coveralls

@WenjieDu WenjieDu merged commit 567e47f into dev May 17, 2024
8 of 9 checks passed
@WenjieDu WenjieDu deleted the (feat)grud_imputation branch May 17, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants