Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Linear Interpolation (Lerp) Imputation Method #459

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

colesussmeier
Copy link
Contributor

What does this PR do?

Add linear interpolation (Lerp) imputation method as a new naive model.

Logic is implemented directly in the model.py file, much like the format for Median/ Mean naive models. Test is implemented in tests/imputation/lerp.py, which matches the format of test files for Median/ Mean exactly. Model name is added to the imputation folder's init file.

  • Was this discussed/approved via a GitHub issue? Link
  • I have written necessary tests and already run them locally.

@coveralls
Copy link
Collaborator

coveralls commented Jul 17, 2024

Pull Request Test Coverage Report for Build 9960916444

Details

  • 56 of 61 (91.8%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 83.86%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/imputation/lerp/model.py 52 57 91.23%
Files with Coverage Reduction New Missed Lines %
pypots/imputation/gpvae/model.py 1 86.21%
Totals Coverage Status
Change from base Build 9787507308: 0.03%
Covered Lines: 10423
Relevant Lines: 12429

💛 - Coveralls

@WenjieDu WenjieDu merged commit b153c2e into WenjieDu:dev Jul 17, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants