Fixed the Giantbomb plugin. #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As chats no longer gives a response and causes an error.
|
There's another issue that happened recently. On this GBE playdate video (put a subscriber key in the url), the object only has I've fixed it here: pwyliu/kodi-giantbomb@0b01522, perhaps this could be added as well. I didn't think it was worth another PR, but if you'd like me to make one I'd be happy to. |
|
I'll update this with it, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The giantbomb plugin is now using the API url: www.giantbomb.com/api, instead of api.giantbomb.com. I also had to change the response test to use a different URL as /chats/ was no longer responding.
This plugin will need to be updated in the add-on repository too.