Overhaul the extension, release version 1.1.0 [SEL-1057] #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Require MediaWiki 1.39+ and run CI against 1.39 * Drop use of `estahn/phpunit-json-assertions` - while our test action does merge dev dependencies, MediaWiki generally doesn't - instead, implement the validation of the JSON against the schema using the available `justinrainbow/json-schema` library * Update `PagePortTest` to extend `MediaWikiIntegrationTestCase`; `MediaWikiTestCase` was dropped in 1.38, see `bf56204` in core * Update `PagePort` to use `WikiPage::doUserEditContent()`, `::doEditContent()` was dropped in 1.39, see `0e39420` in core * Update `PagePort` to use `IResultWrapper::fetchRow()` and `::free()`; the corresponding methods `::fetchRow()` and `::freeResult()` were removed from the IDatabase interface in 1.39, see `46374a8` in core * Update `PagePort` to use the `NamespaceInfo` service; the `MWNamespace` class was removed in 1.39, see `ea1c106` in core * Update `PagePort` to use `WikiPage::doDeleteArticleReal()`; `::doDeleteArticle()` was dropped in 1.36, see `7cffa71` in core * Add tests for `PagePort::getAllPages()` and `::delete()`
* Add git attributes * CI: run phan and make pass: drop redundant conditions, use `?:` syntax, fix documentation, and iterate through result sets * CI: run phpcs and make pass; most notably, drop fallback to `$wgContLang` when the content language service is not available; it has been available since 1.32, see `1e07965` in core * Remove unneeded files and extension.json entries: ** Since 1.28 tests have been automatically discovered under the `tests/phpunit/` directory, see `1d7221d` in core. Accordingly, drop the handling of the `UnitTestsList` hook. ** Nothing in this extension needs aliases defined, and the aliases currently defined are unused. Accordingly, drop the extension aliases file. ** This extension has no ResourceLoader modules or other files that would be linted by NPM tools. Accordingly, delete the eslint and stylelint configurations, and the gruntfile and package.json configurations. Also remove the unused ResourceLoader-related entries from extension.json. ** Remove unused and incorrect `.gitreview` which seems to have been copied from CentralAuth. ** Remove empty `config` entry from extension.json. * Convert PagePort to a service. * Drop `PagePort::getAllCategories()` and replace its caller with a simpler check,
1.1 since there are no breaking changes Also add myself as an author given how much I refactored
vedmaka
approved these changes
Aug 15, 2024
vedmaka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
estahn/phpunit-json-assertionstest dependencyPagePortclass to a service