Skip to content

Commit

Permalink
feat(pg_dump): Add '--if-exists' option for pg_dump (jazzband#478)
Browse files Browse the repository at this point in the history
  • Loading branch information
DmytroLitvinov authored and WillNilges committed Apr 2, 2024
1 parent 3ccac96 commit 1c26b21
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 0 deletions.
4 changes: 4 additions & 0 deletions dbbackup/db/postgresql.py
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ class PgDumpBinaryConnector(PgDumpConnector):
restore_cmd = "pg_restore"
single_transaction = True
drop = True
if_exists = False

def _create_dump(self):
cmd = f"{self.dump_cmd} "
Expand Down Expand Up @@ -145,6 +146,9 @@ def _restore_dump(self, dump):
if self.schemas:
cmd += " -n " + " -n ".join(self.schemas)

if self.if_exists:
cmd += " --if-exists"

cmd = f"{self.restore_prefix} {cmd} {self.restore_suffix}"
stdout, stderr = self.run_command(cmd, stdin=dump, env=self.restore_env)
return stdout, stderr
1 change: 1 addition & 0 deletions docs/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Unreleased
* Add PostgreSQL Schema support by @angryfoxx in https://github.com/jazzband/django-dbbackup/pull/507
* Fix restore of database from S3 storage by reintroducing inputfile.seek(0) to utils.uncompress_file
* Fix bug where dbbackup management command would not respect settings.py:DBBACKUP_DATABASES
* Add option `--if-exists` for pg_dump command

4.1.0 (2024-01-14)
------------------
Expand Down
7 changes: 7 additions & 0 deletions docs/databases.rst
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,13 @@ This corresponds to ``--clean`` argument of ``pg_dump`` and ``pg_restore``.

Default: ``True``

IF_EXISTS
~~~~

Use DROP ... IF EXISTS commands to drop objects in ``--clean`` mode of ``pg_dump``.

Default: ``False``

PostGIS
-------

Expand Down

0 comments on commit 1c26b21

Please sign in to comment.