Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full note when hovering notes icon #198

Merged
merged 8 commits into from
Dec 15, 2024

Conversation

FaceCrap
Copy link
Contributor

Shows the full note text if more than one line.

Shows the full note text if more than one line.
@Willy-JL
Copy link
Owner

hmm how about putting this on the pink notes icon, and regardless of it being more than 1 line? that way even with the notes column disabled you can check notes quickly

@Willy-JL Willy-JL added the enhancement New enhancement or request label Dec 12, 2024
@FaceCrap
Copy link
Contributor Author

hmm how about putting this on the pink notes icon, and regardless of it being more than 1 line? that way even with the notes column disabled you can check notes quickly

Actually that sounds even better. I was still considering to change it so it would also show single line notes if they didn't fit the column width, but never considered the icon. It's even a better solution. (Had to stop and think for a moment which icon you meant.)

Will change it and update the PR

@FaceCrap
Copy link
Contributor Author

FaceCrap commented Dec 13, 2024

Hmm, I'm wondering, to be honest, I've not yet spent much time examing if there's a specific reason not to.
But seeing there's a draw_hover_text, why not use that every time you need to show a tooltip?
EDIT: Looking wherever begin_tooltip is used, I can see most instances where draw_hover_text couldn't be used, but I also found a few that I think could be replaced...

In the case of game.notes I opted to call draw_hover_text instead of my original implementation.

Also added it to the grid/kanban views.

@Willy-JL Willy-JL changed the title Show full note on hover Show full note when hovering notes icon Dec 15, 2024
@Willy-JL Willy-JL merged commit 36cbc39 into Willy-JL:main Dec 15, 2024
@FaceCrap FaceCrap deleted the full-note-on-hover branch December 16, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New enhancement or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants